Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup sofle #22934

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Fixup sofle #22934

merged 3 commits into from
Jan 23, 2024

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Jan 20, 2024 •
edited
Loading

Description

  • Top level info.json file containing common configuration
  • Add keyboard level encoder/OLED functions
  • Size reduction
  • Other misc tidying

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 20, 2024
@waffle87 waffle87 requested a review from a team January 20, 2024 17:54
zvecr
zvecr requested changes Jan 20, 2024
View reviewed changes
keyboards/sofle/info.json Outdated Show resolved Hide resolved
@waffle87 @zvecr
Update keyboards/sofle/info.json
0a877ba 
Co-authored-by: Joel Challis <git@zvecr.com>
drashna
drashna reviewed Jan 20, 2024
View reviewed changes
keyboards/sofle/keyhive/config.h Outdated Show resolved Hide resolved
keyboards/sofle/info.json Outdated Show resolved Hide resolved
@waffle87 @drashna
Update keyboards/sofle/info.json
bc72205 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@zvecr zvecr merged commit e446366 into qmk:develop Jan 23, 2024
1 of 3 checks passed
@waffle87 waffle87 deleted the fix/sofle branch January 23, 2024 17:14
@joshdick joshdick mentioned this pull request Mar 10, 2024
Open
2 tasks
haunt98 added a commit to haunt98/qmk_keymaps that referenced this pull request Apr 18, 2024
@haunt98
feat(qmk): use tri layers
e1573fa 
See qmk/qmk_firmware#22934
@haunt98 haunt98 mentioned this pull request Apr 19, 2024
Closed
2 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@waffle87 @zvecr
@drashna @nuess0r
Fixup sofle (qmk#22934)
0a8d4a6 
* initial

* Update keyboards/sofle/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/sofle/info.json

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @drashna @zvecr