Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cirque connected check #22948

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix cirque connected check #22948

merged 1 commit into from
Jan 23, 2024

Conversation

daskygit
Copy link
Member

Description

I've not been able to test this myself yet but it has been tested by a Discord user that was experiencing the issue. https://discord.com/channels/440868230475677696/440868230475677698/1198671176902393947

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 22, 2024
drashna
drashna approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also confirm that it works

@drashna drashna requested a review from a team January 23, 2024 01:58
@zvecr zvecr merged commit 2c3d012 into qmk:develop Jan 23, 2024
2 of 3 checks passed
@daskygit daskygit deleted the fix/cirque_connect_check branch June 28, 2024 21:35
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@daskygit @nuess0r
crique zidle fix (qmk#22948)
3f34f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @zvecr