Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin removal of bootmagic lite terminology #22970

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Begin removal of bootmagic lite terminology #22970

merged 1 commit into from
Jan 28, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 27, 2024

Description

As full bootmagic has been removed for a while now,

  • implement bootmagic as generic feature
  • rename files to remove _lite
  • move magic functionality to quantum_init

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 27, 2024
@zvecr zvecr merged commit 5cd31fd into develop Jan 28, 2024
3 of 4 checks passed
@zvecr zvecr deleted the bootmagic_tidy1 branch January 28, 2024 22:52
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants