Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of bootmagic lite terminology #22979

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Removal of bootmagic lite terminology #22979

merged 1 commit into from
Feb 17, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 28, 2024

Description

Partial backwards compatibility, as adding handling to check for _lite functions exist causes firmware to oversize.

Opportunity here to change bootmagic_lite(), currently bootmagic_scan(), to something more descriptive of the action it performs?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review January 28, 2024 23:52
@zvecr zvecr force-pushed the bootmagic_tidy2 branch 2 times, most recently from aeecd1d to fe7e7de Compare February 4, 2024 06:43
@infinityis
Copy link
Contributor

Agreed that there is substantial opportunity for a more descriptive, less intimidating name than bootmagic:

  • should_jump_to_bootloader
  • boot_decision
  • boot_selector
  • startup_selector
  • go_to_bootloader
  • bootloader_check

And some far-less-likely candidates that still get honorable mentions:

  • boot_mcbootloader
  • to_boot_or_not_to_boot
  • i_like_big_bootloaders
  • give_me_bootloader_or_give_me_main_program
  • booter_late_than_never
  • yo_firmware_imma_let_you_boot
  • boot_and_the_beast

@zvecr zvecr merged commit e2dbe39 into develop Feb 17, 2024
4 of 5 checks passed
@zvecr zvecr deleted the bootmagic_tidy2 branch February 17, 2024 12:27
Cipulot added a commit to Cipulot/qmk_firmware that referenced this pull request Feb 25, 2024
Change of function name to adhere to the merge in qmk#22979

Co-authored-by: Joel Challis <git@zvecr.com>
haunt98 added a commit to haunt98/qmk_keymaps that referenced this pull request Mar 10, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants