Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init pins for Analog Joystick sensor #22985

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Init pins for Analog Joystick sensor #22985

merged 1 commit into from
Jan 30, 2024

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 30, 2024

Description

Pins for ADC on analog joystick sensor were never initialized. Would work fine in many cases but causes issues on some controllers.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 30, 2024 05:44
@github-actions github-actions bot added the core label Jan 30, 2024
@zvecr zvecr merged commit b910b12 into qmk:develop Jan 30, 2024
2 of 3 checks passed
@drashna drashna deleted the fix/analog_joy_point branch January 31, 2024 18:24
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@drashna @nuess0r
Init pins for Analog Joystick sensor (qmk#22985)
8845b74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @zvecr