Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS2812 PWM: prefix for DMA defines #23111

Merged
merged 2 commits into from
Mar 2, 2024
Merged

WS2812 PWM: prefix for DMA defines #23111

merged 2 commits into from
Mar 2, 2024

Conversation

fauxpark
Copy link
Member

Description

The PWM driver is (currently) the only one which uses DMA, so these should be prefixed WS2812_PWM.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 19, 2024 13:11
@drashna drashna requested a review from a team March 2, 2024 06:23
@zvecr zvecr merged commit 569b0c7 into qmk:develop Mar 2, 2024
3 of 5 checks passed
@fauxpark fauxpark deleted the ws2812-pwm-dma-defines branch March 2, 2024 22:23
dunk2k pushed a commit to dunk2k/qmk_firmware that referenced this pull request Mar 11, 2024
@fauxpark @dunk2k
WS2812 PWM: prefix for DMA defines (qmk#23111)
1e72453 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@fauxpark @mechlovin
WS2812 PWM: prefix for DMA defines (qmk#23111)
902063a 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@fauxpark @mechlovin
WS2812 PWM: prefix for DMA defines (qmk#23111)
68ec301 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@fauxpark @mechlovin
WS2812 PWM: prefix for DMA defines (qmk#23111)
6149d83 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
@lesshonor lesshonor mentioned this pull request Apr 15, 2024
Merged
14 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
WS2812 PWM: prefix for DMA defines (qmk#23111)
3cce5e9 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
WS2812 PWM: prefix for DMA defines (qmk#23111)
21d0c0e 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
WS2812 PWM: prefix for DMA defines (qmk#23111)
f5900d9 
* WS2812 PWM: prefix for DMA defines

* Add backward compatibility defines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr