Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup mechlovin/octagon #23179

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fixup mechlovin/octagon #23179

merged 2 commits into from
Feb 29, 2024

Conversation

waffle87
Copy link
Member

Description

  • Migrate features to info.json
  • Disable features and RGB Light effects to reduce firmware size
  • Tidy up keymaps
  • Use switch statement instead of if/else in octagon.c

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 28, 2024
@waffle87 waffle87 requested a review from a team February 28, 2024 20:40
@waffle87 waffle87 merged commit 4e953f1 into qmk:develop Feb 29, 2024
3 checks passed
@waffle87 waffle87 deleted the fix/octagon branch February 29, 2024 02:13
dunk2k pushed a commit to dunk2k/qmk_firmware that referenced this pull request Mar 11, 2024
@waffle87 @dunk2k
Fixup mechlovin/octagon (qmk#23179)
0d0560d 
* initial

* replace led count
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@waffle87 @mechlovin
Fixup mechlovin/octagon (qmk#23179)
392c9db 
* initial

* replace led count
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@waffle87 @mechlovin
Fixup mechlovin/octagon (qmk#23179)
673b217 
* initial

* replace led count
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@waffle87 @mechlovin
Fixup mechlovin/octagon (qmk#23179)
cf4ce5a 
* initial

* replace led count
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@waffle87 @whoisjordangarcia
Fixup mechlovin/octagon (qmk#23179)
d5caf77 
* initial

* replace led count
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@waffle87 @nuess0r
Fixup mechlovin/octagon (qmk#23179)
86903a2 
* initial

* replace led count
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@waffle87 @Ardakilic
Fixup mechlovin/octagon (qmk#23179)
45a2e51 
* initial

* replace led count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waffle87 @fauxpark