Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epomaker tide75 #23552

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Epomaker tide75 #23552

wants to merge 12 commits into from

Conversation

Epomaker
Copy link
Contributor

@Epomaker Epomaker commented Apr 18, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 18, 2024
Co-authored-by: jack <0x6a73@protonmail.com>
@Epomaker
Copy link
Contributor Author

@waffle87
I have completed the work on this Pull Request and am ready to merge it into the main branch. However, I have found that the merge operation is currently restricted, and only authorized users can perform it.

Could you please help me merge this Pull Request? If you have any questions or need further information, please feel free to let me know. Thank you!

@adophoxia
Copy link
Contributor

@Epomaker

However, I have found that the merge operation is currently restricted, and only authorized users can perform it.

This will only be for people like the collaborators like waffle87, or more so directors like tzarc. So only they have the power for merging PRs like this.

Could you please help me merge this Pull Request?

The easiest way you can make this PR go smoothly is if you follow the requested changes from any reviews made, and to not leave them unnoticed for months as some PRs in the past have done so.

@Epomaker
Copy link
Contributor Author

Epomaker commented Apr 22, 2024

@adophoxia

@Epomaker

However, I have found that the merge operation is currently restricted, and only authorized users can perform it.

This will only be for people like the collaborators like waffle87, or more so directors like tzarc. So only they have the power for merging PRs like this.

Could you please help me merge this Pull Request?

The easiest way you can make this PR go smoothly is if you follow the requested changes from any reviews made, and to not leave them unnoticed for months as some PRs in the past have done so.

I sincerely appreciate your detailed feedback and guidance. I'm committed to meticulously addressing the reviewers' suggestions and actively monitoring the progress of this PR. With our collective effort, I'm confident we can swiftly merge this PR.

@Epomaker
Copy link
Contributor Author

@waffle87
Hi there! I've just uploaded my code. I'd be grateful if you could take a look and provide some feedback. If you see any areas for improvement, please don't hesitate to let me know. I'm eager to learn and make the necessary changes as soon as possible. Thanks in advance!

"force_nkro": true,
"pid": "0xE471",
"suspend_wakeup_delay": 1000,
"vid": "0x342D"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be Westberry's vendor ID. Do you have permission from them to use this VID+PID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have permission to use it. We applied to Westberry.

@tzarc tzarc marked this pull request as draft May 16, 2024 00:59
@tzarc tzarc added invalid pr_checklist_pending Needs changes as per the PR checklist no-ci Signals to the CI runners not to build. crippled-firmware labels May 16, 2024
@tzarc
Copy link
Member

tzarc commented May 16, 2024

Converted to draft and marked with needs-wireless-code due to Tide65 being merged without wireless bindings.
All Epomaker wireless boards are now on hold until Tide65 is rectified. Tide75 will need bindings too.

As per the PR Checklist:
image

@tzarc
Copy link
Member

tzarc commented Jul 10, 2024

This PR is on hold until #24085 is rectified.

@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crippled-firmware invalid keyboard keymap no-ci Signals to the CI runners not to build. pr_checklist_pending Needs changes as per the PR checklist via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants