Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] Inlay hint provider #12

Closed
wants to merge 1 commit into from
Closed

[ESQL] Inlay hint provider #12

wants to merge 1 commit into from

Conversation

qn895
Copy link
Owner

@qn895 qn895 commented Aug 22, 2024

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@@ -380,6 +392,22 @@ export const CodeEditor: React.FC<CodeEditorProps> = ({
if (codeActions) {
monaco.languages.registerCodeActionProvider(languageId, codeActions);
}

if (true) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this if true, but basically debugged that monaco.languages.registerInlayHintsProvider(languageId, inlayHintsProvider); is correctly called

range: monaco.Range,
token: monaco.CancellationToken
): Promise<ProviderResult<InlayHintList>> {
console.log(`--@@getInlayHintsProvider provideInlayHints`);
Copy link
Owner Author

@qn895 qn895 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this line console.log(`--@@getInlayHintsProvider provideInlayHints`); is never triggered

@qn895 qn895 closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant