-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Parametric types #234
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
- Coverage 99.56% 99.47% -0.1%
=========================================
Files 35 35
Lines 2325 2297 -28
=========================================
- Hits 2315 2285 -30
- Misses 10 12 +2
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started addressing #189 here. There are still a lot of things to do in order to get to a fully type-stable point. The following points need to be done in order for this PR to be complete:
Bra
/Ket
CompositeBasis
Operator
type toAbstractOperator
SparseOperator
andDenseOperator
by a singleOperator
type with parametric fieldsgemv!
andgemm!
definitions bymul!
Lazy
,FFT
, ...)IncompatibleBases
errors will be covered by aMethodError
Going type stable will boost overall performance (though probably not by much). Also, this will add support for sparse density matrices, which can be very useful.