move nsubsystems to QuantumInterface (#146)

Co-authored-by: Stefan Krastanov <stefan@krastanov.org>
qojulia · Sep 22, 2023 · 06809f7 · 06809f7 · Krastanov · Sep 22, 2023
1 parent 3a63760
commit 06809f7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "QuantumOpticsBase"
 uuid = "4f57444f-1401-5e15-980d-4471b28d5678"
-version = "0.4.16"
+version = "0.4.17"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
@@ -24,7 +24,7 @@ FastExpm = "1.1.0"
 FastGaussQuadrature = "0.5"
 FillArrays = "0.13, 1"
 LRUCache = "1"
-QuantumInterface = "0.3.0"
+QuantumInterface = "0.3.3"
 RandomMatrices = "0.5"
 Strided = "1, 2"
 UnsafeArrays = "1"

diff --git a/src/QuantumOpticsBase.jl b/src/QuantumOpticsBase.jl
@@ -3,7 +3,7 @@ module QuantumOpticsBase
 using SparseArrays, LinearAlgebra, LRUCache, Strided, UnsafeArrays, FillArrays
 import LinearAlgebra: mul!, rmul!
 
-import QuantumInterface: dagger, directsum, ⊕, dm, embed, expect, identityoperator, identitysuperoperator,
+import QuantumInterface: dagger, directsum, ⊕, dm, embed, nsubsystems, expect, identityoperator, identitysuperoperator,
         permutesystems, projector, ptrace, reduced, tensor, ⊗, variance, apply!, basis, AbstractSuperOperator
 
 # index helpers

diff --git a/src/apply.jl b/src/apply.jl
@@ -1,11 +1,3 @@
-nsubsystems(s::Ket) = nsubsystems(s.basis)
-function nsubsystems(s::Operator)
-    s.basis_l == s.basis_r || throw(ArgumentError("`nsubsystem(::Operator)` is well defined only if the left and right bases are the same"))
-    nsubsystems(s.basis_l)
-end
-nsubsystems(b::CompositeBasis) = length(b.bases)
-nsubsystems(b::Basis) = 1
-
 function is_apply_shortcircuit(state, indices, operation)
     if nsubsystems(state) == 1
         basis(state)==basis(operation) || throw(ArgumentError("`apply!` failed due to incompatible bases of the state and the operation attempted to be applied on it"))