Skip to content

Commit

Permalink
Merge pull request #557 from qonversion/release/5.12.6
Browse files Browse the repository at this point in the history
Release 5.12.6
  • Loading branch information
suriksarkisyan authored Nov 1, 2024
2 parents b7f6441 + c2ff6f8 commit 65b3445
Show file tree
Hide file tree
Showing 6 changed files with 40 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Framework/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>5.12.5</string>
<string>5.12.6</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
Expand Down
2 changes: 1 addition & 1 deletion Qonversion.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Pod::Spec.new do |s|
idfa_exclude_files = ['Sources/Qonversion/IDFA']
s.name = 'Qonversion'
s.swift_version = '5.5'
s.version = '5.12.5'
s.version = '5.12.6'
s.summary = 'qonversion.io'
s.description = <<-DESC
Deep Analytics for iOS Subscriptions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,32 @@ - (void)showAutomationWithID:(NSString *)automationID completion:(nullable QONSh
if (configuration.presentationStyle == QONScreenPresentationStylePush) {
[presentationViewController.navigationController pushViewController:viewController animated:configuration.animated];
} else {
QONAutomationsNavigationController *navigationController = [[QONAutomationsNavigationController alloc] initWithRootViewController:viewController];
navigationController.navigationBarHidden = YES;
UIModalPresentationStyle style = configuration.presentationStyle == QONScreenPresentationStylePopover ? UIModalPresentationPopover : UIModalPresentationFullScreen;
navigationController.modalPresentationStyle = style;
[presentationViewController presentViewController:navigationController animated:configuration.animated completion:nil];

if (style == UIModalPresentationPopover) {
viewController.modalPresentationStyle = style;

UIView *sourceView = nil;
if ([weakSelf.screenCustomizationDelegate respondsToSelector:@selector(viewForPopoverPresentation)]) {
sourceView = [weakSelf.screenCustomizationDelegate viewForPopoverPresentation];
}

if (sourceView) {
viewController.popoverPresentationController.sourceRect = sourceView.bounds;
viewController.popoverPresentationController.sourceView = sourceView;
} else {
viewController.popoverPresentationController.permittedArrowDirections = 0;
viewController.popoverPresentationController.sourceRect = CGRectMake(CGRectGetMidX(presentationViewController.view.bounds), CGRectGetMidY(presentationViewController.view.bounds),0,0);
viewController.popoverPresentationController.sourceView = presentationViewController.view;
}

[presentationViewController presentViewController:viewController animated:configuration.animated completion:nil];
} else {
QONAutomationsNavigationController *navigationController = [[QONAutomationsNavigationController alloc] initWithRootViewController:viewController];
navigationController.navigationBarHidden = YES;
navigationController.modalPresentationStyle = style;
[presentationViewController presentViewController:navigationController animated:configuration.animated completion:nil];
}
}

run_block_on_main(completion, true, nil);
Expand Down
2 changes: 1 addition & 1 deletion Sources/Qonversion/Public/QONConfiguration.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#import "QONConfiguration.h"
#import "QNAPIConstants.h"

static NSString *const kSDKVersion = @"5.12.5";
static NSString *const kSDKVersion = @"5.12.6";

@interface QONConfiguration ()

Expand Down
10 changes: 10 additions & 0 deletions Sources/Qonversion/Public/QONScreenCustomizationDelegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

#import "QONScreenPresentationConfiguration.h"

@class UIView;

/**
The delegate is responsible for customizing screens representation
*/
Expand All @@ -23,4 +25,12 @@ NS_SWIFT_NAME(Qonversion.ScreenCustomizationDelegate)
- (QONScreenPresentationConfiguration * _Nonnull)presentationConfigurationForScreen:(NSString * _Nonnull)screenId
NS_SWIFT_NAME(presentationConfigurationForScreen(_:));;

/**
View for popover presentation style for iPad. A new popover will be presented from this view
Used only for Qonversion.ScreenPresentationStyle == .popover for iPad.
You can omit implementing this delegate function if you do not support iPad or do not use popover presentation style.
*/
- (UIView * _Nullable)viewForPopoverPresentation
NS_SWIFT_NAME(viewForPopoverPresentation());

@end
4 changes: 2 additions & 2 deletions fastlane/report.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@



<testcase classname="fastlane.lanes" name="0: update_plist" time="0.007282">
<testcase classname="fastlane.lanes" name="0: update_plist" time="0.007936">

</testcase>


<testcase classname="fastlane.lanes" name="1: version_bump_podspec" time="0.000657">
<testcase classname="fastlane.lanes" name="1: version_bump_podspec" time="0.000701">

</testcase>

Expand Down

0 comments on commit 65b3445

Please sign in to comment.