Added rate limits for API calls #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suriksarkisyan
approved these changes
Sep 18, 2023
Sources/Qonversion/Qonversion/Constants/QNAPIConstants/QNAPIConstants.h
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Constants/QNAPIConstants/QNAPIConstants.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Services/QNAPIClient/QNAPIClient.m
Outdated
Show resolved
Hide resolved
Comment on lines
+136
to
+138
| if (rateLimitError != nil) { | ||
| completion(nil, rateLimitError); | ||
| return; |
There was a problem hiding this comment.
I don't like that we need to copy/paste this block of code. But probably it's the best way to not complicate this part of code. What do you think about alternatives? Any idea?
Sources/Qonversion/Qonversion/Utils/QNRateLimiter/QONRateLimiter.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Utils/QNRateLimiter/QONRateLimiter.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Utils/QNRateLimiter/QONRateLimiter.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Utils/QNRateLimiter/QONRateLimiter.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Utils/QNRateLimiter/QONRateLimiter.m
Outdated
Show resolved
Hide resolved
suriksarkisyan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.