feat(StringUtil): implement format placeholders closer to _posix parameter expansion_ - i.e. implement optional colon #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter expansion_ - i.e. implement optional colon
|
LGTM |
|
Thx @IvanGrund, feel free to try version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is: If branch name is develop, version should be develop-SNAPSHOT. If branch name is feature/JIRA-12345, version should be ~JIRA-12345-SNAPSHOT, so it is alphabeticaly always later (newer). The tilda should be added only if prefix "feature/" is present i.e. ${prefix:+~}.
The problem is, that even if prefix is not defined current implementation creates ${prefix} with empty string, so the overwriting happen. My PR adds possibility to treat empty string as variable not defined.