-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to sass #10215
Move to sass #10215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thank you very much!
Does this solve the compatibility problem with jsdom? |
Not in generally. It solves the problem loading sass in qooxdoo compiler. We do not use jsdom there - we use outr own generated windows problem. You can use this approach to load sass with jsdom. I have'nt tried it it. process.versions.electron = "0.0.0"; Tells sass that we are in a node enviroment |
sass seems quite a bit slower ... but then again, I guess we do not have a performance problem there, or do we? |
No we do not have a performance problem.
|
* qooxdoo/qooxdoo#10214: fix missing typescript template * backport qooxdoo/qooxdoo#10215 move to sass
see #10146.
I found a way to trick out the sass loading problem.
This should solve all node-sass problems.
Should be backportet to compiler