Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to sass #10215

Merged
merged 7 commits into from
Jun 16, 2021
Merged

Move to sass #10215

merged 7 commits into from
Jun 16, 2021

Conversation

hkollmann
Copy link
Member

see #10146.
I found a way to trick out the sass loading problem.
This should solve all node-sass problems.

Should be backportet to compiler

Copy link
Contributor

@cboulanger cboulanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you very much!

@johnspackman
Copy link
Member

Does this solve the compatibility problem with jsdom?

@hkollmann
Copy link
Member Author

Does this solve the compatibility problem with jsdom?

Not in generally. It solves the problem loading sass in qooxdoo compiler. We do not use jsdom there - we use outr own generated windows problem.

You can use this approach to load sass with jsdom. I have'nt tried it it.
The idea is to trick out sass:

process.versions.electron = "0.0.0"; Tells sass that we are in a node enviroment
window.document.currentScript = {src: ""}; Prevents sass to access to the document.scripts variable

@oetiker
Copy link
Member

oetiker commented Jun 11, 2021

sass seems quite a bit slower ... but then again, I guess we do not have a performance problem there, or do we?
https://www.peterbe.com/plog/quick-comparison-between-sass-and-node-sass

@hkollmann
Copy link
Member Author

sass seems quite a bit slower ... but then again, I guess we do not have a performance problem there, or do we?
https://www.peterbe.com/plog/quick-comparison-between-sass-and-node-sass

No we do not have a performance problem.
We do have the problem that node-sass

@johnspackman johnspackman merged commit 4ed0ffa into qooxdoo:master Jun 16, 2021
@hkollmann hkollmann deleted the move_to_sass branch July 22, 2021 20:46
hkollmann added a commit to qooxdoo/qooxdoo-compiler that referenced this pull request Jul 23, 2021
* qooxdoo/qooxdoo#10214: fix missing typescript template
* backport qooxdoo/qooxdoo#10215 move to sass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants