This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced periodic socket timeouts on the client side as well as server side 504 errors while using the loggly appenders, both of which seem to be temporary conditions. I added retry logic to both appenders that will retry failed requests up to the specified number of times. The default retry limit is 3 retries, but the user can specify the max retry limit in the appender configurations.
For the batch appender, I do not increment the failure count unless the retry limit has been reached.
The retry logic has thus far eliminated the periodic failures I was experiences (e.g. the request has always been successful on subsequent tries).