-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal refactor to support more token types - part 1/??? #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question, why is it TokenLikeName? To me ClassLikeName makes sense, because it can be something like a trait or interface, so it's not strictly speaking a class, but now we have a token and its name, or not?
Naming things is hard, |
@dbrumann I think I am done with this pass. More changes might be needed, but I will discover those only when I will try to write another |
{ | ||
public function getName(): string | ||
{ | ||
return 'BasicDependencyEmitter'; | ||
return 'UsesDependencyEmitter'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder for myself, docs/concepts.md
contains a code snippet with the old emitter name that we probably should update later.
Relates: #582