-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance issue #799
Conversation
aab743d
to
1218179
Compare
1218179
to
7cc648c
Compare
@@ -59,4 +59,19 @@ public function testIncludesFQDNWhichIsAlsoANamespacePrefix(): void | |||
self::assertCount(1, $deps); | |||
self::assertContains('FQDNNamespacePrefix\Uses\Foo:5 on FQDNNamespacePrefix\FQDN', $deps); | |||
} | |||
|
|||
public function testIncludesFQDNWhichIsDoesNotExistAndSubstringOfAnotherFQDN(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a case that shows the difference between main and my PR. This test will fail on main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I will prepare a release with this fix later today
Closes #798
versus vanila 0.19.1