#56 fix: complain about already existing menu items

qownnotes · Feb 6, 2024 · d5f71bf · d5f71bf
1 parent f923d0f
commit d5f71bf
Showing 1 changed file with 22 additions and 18 deletions.
diff --git a/src-bex/background.js b/src-bex/background.js
@@ -374,27 +374,31 @@ chrome.storage.onChanged.addListener(function () {
   loadSettings();
 });
 
-const mainMenu = chrome.contextMenus.create({
-  "id": "mainMenu-root",
-  "title": "QOwnNotes", "contexts": ["page"]
-});
+// Make sure old context menus are removed before creating new ones in case
+// of the background script being reloaded
+chrome.contextMenus.removeAll(() => {
+  const mainMenu = chrome.contextMenus.create({
+    "id": "mainMenu-root",
+    "title": "QOwnNotes", "contexts": ["page"]
+  });
 
-chrome.contextMenus.create({
-  "id": "mainMenu-sendPageToQOwnNotes",
-  "title": getLocale('sendPageToQOwnNotes'), "contexts": ["page"],
-  "parentId": mainMenu
-});
+  chrome.contextMenus.create({
+    "id": "mainMenu-sendPageToQOwnNotes",
+    "title": getLocale('sendPageToQOwnNotes'), "contexts": ["page"],
+    "parentId": mainMenu
+  });
 
-chrome.contextMenus.create({
-  "id": "mainMenu-createScreenshotNote",
-  "title": getLocale('createScreenshotNote'), "contexts": ["page"],
-  "parentId": mainMenu
-});
+  chrome.contextMenus.create({
+    "id": "mainMenu-createScreenshotNote",
+    "title": getLocale('createScreenshotNote'), "contexts": ["page"],
+    "parentId": mainMenu
+  });
 
-chrome.contextMenus.create({
-  "id": "mainMenu-sendSelectionToQOwnNotes",
-  "title": getLocale('sendSelectionToQOwnNotes'), "contexts": ["selection"],
-  "parentId": null
+  chrome.contextMenus.create({
+    "id": "mainMenu-sendSelectionToQOwnNotes",
+    "title": getLocale('sendSelectionToQOwnNotes'), "contexts": ["selection"],
+    "parentId": null
+  });
 });
 
 chrome.contextMenus.onClicked.addListener(function(info, tab) {