Can't trigger extension using keyboard shortcut in Firefox

[husimo-tilleuls]

Expected behaviour

Would like to be able to use the QOwnNotes web companion using keyboard shortcut Ctrl + Shift + B

Actual behaviour

It triggers the bookmarks bar (displays and hides).

Steps to reproduce

Maybe it's related to a French Firefox version, i dunno.

Output from the debug section in the settings dialog in QOwnNotes

Don't think it's relevant here but can send it if necessary

Relevant log output in the Log panel in QOwnNotes

Don't think it's relevant here but can send it if necessary

[pbek]

I guess (your?) Firefox doesn't honor the default shortcut set here:

web-companion/app/manifest.json

Lines 68 to 72 in a599247

	"__firefox__commands": {
	"_execute_browser_action": {
	"suggested_key": { "default": "Ctrl+Shift+B" }
	}
	}

[pbek]

I personally use Ctrl+Alt+B everywhere. Maybe I just set that as default too now...

[husimo-tilleuls]

Indeed : https://support.mozilla.org/en-US/questions/1317877

Ctrl+Shift+B now toggles the Bookmarks Toolbar.

Do you think it would be possible to implement other shortcuts like Chrome ?

[pbek]

What "other shortcuts like Chrome"?

[husimo-tilleuls]

As listed here : https://github.com/qownnotes/web-companion#chrome ; there's only one listed for Firefox versus more for Chrome

[pbek]

Those just use HTML Access Keys, they should also work under Firefox, see https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey. Thank you, I'll add the link to the README.

[husimo-tilleuls]

Okay, nice. I tried it the first one : https://github.com/qownnotes/web-companion/blob/develop/README.md?plain=1#L57

And Firefox triggers the menu bar on Alt key ;'(

[pbek]

I personally use Ctrl+Alt+B everywhere.

You can set that shortcut too in the Firefox extension settings, those are well hidden in Firefox. 😬

[pbek]

And Firefox triggers the menu bar on Alt key ;'(

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey says Alt + Shift (on Windows and Linux).

[husimo-tilleuls]

Nice, it's working, thank you!

[pbek]

22.12.0

• changed Firefox default shortcut to Ctrl + Alt + B since the browser blocked Ctrl + Shift + B
  (for #48)

There now is a new release, could you please test it and report if it works for you?

[husimo-tilleuls]

Hello, thank you! It's not yet available in my Firefox and I don't have time right now to install it manually but I'll tell you ASAP ;-)

[pbek]

Mozilla needs some time for the review process... ;)

[pbek]

It's online...

[husimo-tilleuls]

LGTM! Thank's a lot!

If there's any way to support your work I would be glad to!

[pbek]

Thank you. :) Reporting issues that creep up when browser vendors change things already helps a lot.