Skip to content

Commit

Permalink
catalog: specify thumbnail size
Browse files Browse the repository at this point in the history
if you just wait 3 years, TODOs just get implemented, yo
  • Loading branch information
qqueue committed Sep 23, 2016
1 parent 2b7cd62 commit a74dab5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions style/catalog.styl
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ cat-width = 150px
overflow hidden

.catalog-thumb
// TODO would prefer to specify width and height in html to prevent
// reflowing, but that would require object-fit CSS to make simple max-width
// scaling 'just werk'.
object-fit contain
max-width cat-width
max-height cat-width // prevent skinny images from being so big

Expand Down
2 changes: 1 addition & 1 deletion templates/catalog-thread.ne
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ a.catalog-link(href="//boards.4chan.org/#{board.name}/thread/#{@@no}",
id="c#{@@no}")
figure.catalog-thread
if @imgurl
img.catalog-thumb(src="//t.4cdn.org/#{board.name}/#{@imgurl}s.jpg")
img.catalog-thumb(src="//t.4cdn.org/#{board.name}/#{@imgurl}s.jpg", width="#{@tn_w}", height="#{@tn_h}")
else
img.catalog-thumb.deleted-image(src="//s.4cdn.org/image/filedeleted.gif")
figcaption.catalog-caption
Expand Down

4 comments on commit a74dab5

@saxamaphone69
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 Am I dreaming, or did this happen?

@vendethiel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it did happen

@vendethiel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never thought the day you get rid of your anime avatar would happen either, but hey it did

@saxamaphone69
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 If it makes you feel better, I still don't know how to build this script, nor have made my own ES6 4chan X-esque Chrome extension. Those things, never change.

Please sign in to comment.