[4337][FIX] stock_picking_auto_create_lot: fix creating lot for 0 qty move lines for serial product #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
16.0-fix-stock_picking_auto_create_lot
branch
from
3d0264e to
4f3dbb2
Compare
AungKoKoLin1997
force-pushed
the
16.0-fix-stock_picking_auto_create_lot
branch
from
4f3dbb2 to
9cb7303
Compare
yostashiro
approved these changes
Feb 26, 2024
yostashiro
reviewed
Feb 26, 2024
| #. module: stock_picking_auto_create_lot | ||
| #: model:ir.model,name:stock_picking_auto_create_lot.model_stock_move_line | ||
| msgid "Product Moves (Stock Move Line)" | ||
| msgstr "プロダクト移動（在庫移動明細）" |
There was a problem hiding this comment.
Suggested change
| msgstr "プロダクト移動（在庫移動明細）" | |
| msgstr "プロダクト移動(在庫移動明細)" |
liuhehe1995
approved these changes
Feb 27, 2024
liuhehe1995
force-pushed
the
16.0-fix-stock_picking_auto_create_lot
branch
from
a587e22 to
a5dbcd8
Compare
kanda999
requested changes
Mar 6, 2024
Comment on lines
25
to
41
|
|
||
| # pylint: disable=missing-return | ||
| def _set_quantities_to_reservation(self): | ||
| super()._set_quantities_to_reservation() | ||
| for move in self: | ||
| if move.state not in ("partially_available", "assigned"): | ||
| continue | ||
| if ( | ||
| move.product_id.tracking == "none" | ||
| or not move.product_id.auto_create_lot | ||
| or not move.picking_type_id.auto_create_lot | ||
| ): | ||
| continue | ||
| for move_line in move.move_line_ids: | ||
| if move_line.lot_id: | ||
| # Create-backorder wizard would open without this. | ||
| move_line.qty_done = move_line.reserved_uom_qty |
There was a problem hiding this comment.
Can you rebase this PR so that this part is not removed?
This module in axls-oca has OCA updates
… move lines for serial product
AungKoKoLin1997
force-pushed
the
16.0-fix-stock_picking_auto_create_lot
branch
from
77a225b to
7d3a1b7
Compare
yostashiro
changed the title
|
I will update to reflect latest OCA changes after #144 is merged to avoid breaking behaviour of customer staging. |
AungKoKoLin1997
force-pushed
the
16.0-fix-stock_picking_auto_create_lot
branch
from
97d0ea3 to
7d3a1b7
Compare
kanda999
reviewed
Jul 12, 2024
| @@ -1,39 +1,12 @@ | |||
| # Copyright 2020 ACSONE SA/NV | |||
| # Copyright 2024 Quartile Limited | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2024 Quartile Limited | |
| # Copyright 2020 ACSONE SA/NV | |
| # Copyright 2024 Quartile Limited |
Please don't remove this.
There was a problem hiding this comment.
It is already removed in OCA because it is removed this file first in OCA repo by another PR that is proposed by other community member. Then, we added this file again because it is needed for some use case. So, I guess we don't need add in our repo as well.
There was a problem hiding this comment.
@AungKoKoLin1997
I understood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4337