[4120][REF][ADD] report_csv, report_format_option #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
reviewed
Mar 26, 2024
| name="encoding" | ||
| attrs="{'invisible': [('report_type', '!=', 'csv')]}" | ||
| /> | ||
| <field name="encoding" /> |
There was a problem hiding this comment.
Can we add a show_encoding compute field and do this?
Suggested change
| <field name="encoding" /> | |
| <field name="encoding" attrs="{'invisible': [('show_encoding', '=', False)]}"/> |
yostashiro
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@AungKoKoLin1997 Please go ahead and create a PR in the OCA repo upon following up on comments.
| @@ -0,0 +1 @@ | |||
| This module adds an encoding option for reports. It is not meant to stand alone; instead, it will be used as a base for other reporting-related modules (e.g., report_csv). | |||
There was a problem hiding this comment.
Suggested change
| This module adds an encoding option for reports. It is not meant to stand alone; instead, it will be used as a base for other reporting-related modules (e.g., report_csv). | |
| This is a technical module to add encoding fields to ir.actions.report model and it does nothing by itself. The module is expected to be a dependency of other reporting modules (e.g., report_csv). |
AungKoKoLin1997
force-pushed
the
16.0-add-report_encoding
branch
2 times, most recently
from
756c455 to
901bea0
Compare
yostashiro
force-pushed
the
16.0-add-report_encoding
branch
from
d5bac16 to
774728b
Compare
yostashiro
changed the title
yostashiro
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4120