Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][3825][IMP] stock_picking_accounting_date, stock_valuation_layer_accounting… #86

Merged
merged 6 commits into from
Nov 7, 2023
Merged

[16.0][3825][IMP] stock_picking_accounting_date, stock_valuation_layer_accounting… #86

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8255da
[IMP] stock_picking_accounting_date, stock_valuation_layer_accounting…
AungKoKoLin1997 Oct 17, 2023
c4041fd
adjs
AungKoKoLin1997 Oct 17, 2023
bc87fe6
change dependency
AungKoKoLin1997 Oct 17, 2023
a464468
remove readonly on accounting_date
rinaldifirdaus Oct 24, 2023
3390c79
set accounting_date readonly on views
rinaldifirdaus Nov 6, 2023
6d3ffca
adjustment
rinaldifirdaus Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stock_picking_accounting_date/views/stock_picking_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
<field name="show_accounting_date" invisible="1" />
<field
name="accounting_date"
attrs="{'invisible': [('show_accounting_date', '=', False)]}"
attrs="{'invisible': [('show_accounting_date', '=', False)],
'readonly': [('show_accounting_date', '=', True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinaldifirdaus Any reason to have this ('show_accounting_date', '=', True)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't define ('show_accounting_date', '=', True), the field with string consumable accounting date will also become readonly as far as i test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the purpose is to make it readonly only when storable product on the transfers. the one with string "Accounting Date".

('state', 'in', ('done', 'cancel'))]}"
/>
</xpath>
</field>
Expand Down
Loading