Skip to content

Commit

Permalink
tst_QHttp2Connection: make settings exchange wait for acknowledgement
Browse files Browse the repository at this point in the history
Is needed when sending more SETTINGS frames during the test later

Task-number: QTBUG-132277
Pick-to: 6.9 6.8
Change-Id: I24b2a5d1b2e7aecd8687db5b24f37233df3b91dd
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
  • Loading branch information
Morten242 committed Dec 20, 2024
1 parent 9f392c0 commit 6e7a15f
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ bool tst_QHttp2Connection::waitForSettingsExchange(QHttp2Connection *client,
client->handleReadyRead(); // handle incoming frames, send response

bool success = QTest::qWaitFor([&]() {
return settingsFrameReceived && serverSettingsFrameReceived;
return settingsFrameReceived && serverSettingsFrameReceived
&& !client->waitingForSettingsACK && !server->waitingForSettingsACK;
});

disconnect(c);
Expand Down

0 comments on commit 6e7a15f

Please sign in to comment.