AtSpiAdaptor: sync Cache signatures to at-spi2-core 2.45.91 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those signatures are the ones used by Gtk for some time now. For Qt it does not make a huge difference, as GetItem returns an empty list and the signals are never emited. The Cache.xml copy had to include a workaround: adding back the direction on signal args, without which qdbusxml2cpp.cpp seems to mistake those for direction="out" and requests "Out0" annotations. Signed-off-by: Yann Dirson <ydirson@free.fr>
|
Qt doesn't use GitHub, this needs to be submitted to Gerrit codereview (https://codereview.qt-project.org/). For instructions see: https://wiki.qt.io/Setting_up_Gerrit and https://wiki.qt.io/Gerrit_Introduction |
langlor-autodesk
added a commit
to autodesk-forks/qtbase
that referenced
this pull request
Feb 6, 2023
* Windows: use QSystemLibrary instead of LoadLibrary directly Using QSystemLibrary ensures that it will only use the expected copy of the system library and not one that has been placed in the application's working directory or elsewhere in the PATH environment variable. Pick-to: 5.15 6.2 6.3 Change-Id: Ic4234334f73482b38ee5f06345bf11f8c029edc5 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> * Windows: use QSystemLibrary instead of LoadLibrary directly (5.15) This is the rest of the patch that is specific to Qt 5.15. Using QSystemLibrary ensures that it will only use the expected copy of the system library and not one that has been placed in the application's working directory or elsewhere in the PATH environment variable. Change-Id: Ic559957f5ca2e53193a1c230577f877b09e90859 Co-authored-by: Andy Shaw <andy.shaw@qt.io> Co-authored-by: Keith Kyzivat <keith.kyzivat@qt.io>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those signatures are the ones used by Gtk for some time now. For Qt it does not make a huge difference, as GetItem returns an empty list and the signals are never emited.
The Cache.xml copy had to include a workaround: adding back the direction on signal args, without which qdbusxml2cpp.cpp seems to mistake those for direction="out" and requests "Out0" annotations.
Signed-off-by: Yann Dirson ydirson@free.fr