Fix: add quote when marshalJSON #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 94.52% 94.57% +0.05%
==========================================
Files 5 5
Lines 1260 1272 +12
==========================================
+ Hits 1191 1203 +12
Misses 37 37
Partials 32 32 ☔ View full report in Codecov by Sentry. |
quagmt
force-pushed
the
fix/marshal-json-with-quote
branch
from
a5095ca
to
65a5789
Compare
ccoVeille
approved these changes
Oct 15, 2024
| } else { | ||
| // if not trimming trailing zeros, we can safely allocate 41 bytes | ||
| // 1 sign + 1 dot + len(u128) (which is max to 39 bytes) | ||
| buf = []byte("00000000000000000000000000000000000000000") | ||
| // buf = []byte("00000000000000000000000000000000000000000") |
There was a problem hiding this comment.
I think this line should have been removed
There was a problem hiding this comment.
I would have committed the benchmark changes for readability purpose. It wasn't easy to review altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description