Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all invocations of logging to LOG. #33

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Replace all invocations of logging to LOG. #33

merged 1 commit into from
Feb 23, 2015

Conversation

seyhuns
Copy link

@seyhuns seyhuns commented Feb 20, 2015

By means of this, logging may be disabled easily when dicttoxml is
used as a library.

Merge conflicts based on #22 are fixed.

By means of this, logging may be disabled easily when dicttoxml is
used as a library.
@haplo
Copy link

haplo commented Feb 20, 2015

It looks like there is one extra logging line that probably was added before @mfriedenhagen created his branch:

logging.info('\nLogging session starts: %s' % (str(datetime.datetime.today())))

@seyhuns Could you update that line too?

@seyhuns
Copy link
Author

seyhuns commented Feb 23, 2015

https://docs.python.org/2/library/logging.html#logging.basicConfig

I believe that set_debug function doesn't have any use case right now. It's modifying root logger which isn't used with this changes.

@haplo
Copy link

haplo commented Feb 23, 2015

@seyhuns I think set_debug should get the dicttoxml logger and add a new FileHandler, that should avoid overriding the root handler.

quandyfactory added a commit that referenced this pull request Feb 23, 2015
Replace all invocations of logging to LOG.
@quandyfactory quandyfactory merged commit 5a9318e into quandyfactory:master Feb 23, 2015
quandyfactory added a commit that referenced this pull request Feb 23, 2015
@seyhuns seyhuns deleted the named-logger branch October 22, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants