Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prod to v0.3.4 - 11/7/2024 #69

Merged
merged 32 commits into from
Nov 7, 2024
Merged

Update Prod to v0.3.4 - 11/7/2024 #69

merged 32 commits into from
Nov 7, 2024

Conversation

alexchao32
Copy link
Collaborator

Headline: [JIRA ID#] Description of changes

Summary of changes:

  • MS1 workflow now correctly identifies all adduct matches when more than one adduct is found for a feature
  • MS1 workflow now correctly identifies which feature is parent and which feature is adduct for neutral loss adduct matches
  • MS2 workflow now generates percentile scores (in addition to the existing raw and quotient scores)
  • Merge workflow now merges MS2 percentile and quotient scores into merge results
  • MS2 workflow: Updated rounding for values, and small bug fixes for empty score cells

How to test:

  • Special instructions on how to install and test the feature/ticket
  • Request extra scrutiny on this or that area of the code or feature
  • Please add any specific commands that might help someone test the ticket.

Test Results:

n.b. Any special insights, instructions, extra tasks, etc.

BEFORE screenshots

Paste in screenshots here

AFTER screenshots/movies/test artifacts

Paste in screenshots here

JeffreyMinucci and others added 30 commits October 3, 2024 15:58
Copy link
Collaborator

@tmferland tmferland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm particularly liking the class structure for merging, looking forward to seeing that fleshed out!

@tmferland tmferland merged commit 4aaa1da into master Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants