-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom override closing tags rendered in Firefox #535
Comments
The following issue was introduced in 7.4: quantizor/markdown-to-jsx#535 Downgrading to 7.3.2 will fix it
Any workarounds for this? I want to be able to use the new Update: I just instead made a self closing custom tag to get around this issue for my case. Easy enough. |
@stevemckenzie yes I ended up doing the same thing. Instead of nesting, make the parent tag contain the child in its render function and make it self-closing |
We where running into the same issue on our application. I saw that storybook rolled back to Tried So we are sticking to |
I was seeing similar behavior. Resolved by downgrading to Noting that |
Had the same issue on version |
The problem was introduced in 1583486 specifically this change: and adding these 3 lines seems to fix the problem:
the reason is that array sort is not stable in firefox. There are 2 other fixes:
@quantizor Can you comment here on what the best fix would be and whether you want a Pr or you will take it from here? |
Hey @quantizor. I'm willing to sponsor this issue and #542 with $100 (via polar.sh) to get it fixed. |
I will try and look at this tonight, thanks for your patience |
@lukeapage Did you end up making a PR for this? Looks easy enough to accept. |
No, I was waiting to hear the correct fix. If you want me to I can but it will be tomorrow. |
@zegl Donations to my Github Sponsor profile are appreciated :) looking at this now |
As of the 7.4 update, custom component overrides that render children are rendering the closing tag in Firefox. This only occurs when the custom component render children; self-closing custom components render correctly. This rendered correctly in version 7.3.2
Code to reproduce
Screenshots
Firefox (the bug occurs)
Chrome (bug does not occur)
The text was updated successfully, but these errors were encountered: