Jupyter notebook 5 compatibility #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanderson
force-pushed
the
ipython6-compat
branch
from
54a2f32 to
7817ff4
Compare
ssanderson
reviewed
Aug 20, 2018
There was a problem hiding this comment.
@TimShawver I updated this to drop support for IPython 3.x. I had two small suggestions on the other changes. Otherwise LGTM.
| # support backing up the deleted directory in the OS trash can. | ||
| # FileContentsManager should allow non-empty directories to be deleted. | ||
| def test_delete_non_empty_dir(self): | ||
| if issubclass(self.notebook.contents_manager_class, |
There was a problem hiding this comment.
I'd probably use isinstance(self.notebook.contents_manager, ...) for these checks rather than issubclass.
pgcontents/pgmanager.py
Outdated
| klass = PostgresContentsManager | ||
| kw = super(klass, self)._checkpoints_kwargs_default() | ||
| except AttributeError: | ||
| kw = {'parent': self, 'log': self.log} |
There was a problem hiding this comment.
This was renamed to _default_checkpoints_kwargs in notebook 5, so we can probably just use that instead of hard-coding a set of defaults.
…cluding when HybridContentsManager contains a FileContentsManager), and continue to test that non-empty folders owned by PostgresContentsManager are not deletable.
…version of IPython beyond checking that it's greater than or equal to 3.
- Drop references to IPython. - Add link to JupyterCon presentation.
…on 5.x (ipykernel gets installed with the notebook). Adds missing comma in ipycompat.py, some comment cleanup.
…ed (I think). Rename the notebook 4 and 5 installations to reflect the fact that ipython is no longer a dependency.
TimShawver
force-pushed
the
ipython6-compat
branch
from
e7c1072 to
c21aef4
Compare
PrestonYadegar
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds on to #44 to make the changes suggested by this comment: https://github.com/quantopian/pgcontents/pull/44/files#r192937051