Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas append() method depreciated, replace all occurrences with concat() #126

Closed
EwoutH opened this issue May 16, 2022 · 4 comments
Closed

Comments

@EwoutH
Copy link
Collaborator

EwoutH commented May 16, 2022

Using DataFrame.append() is depreciated with Pandas 1.4. All occurrences should be replaced with pandas.concat() to ensure compatibility with future Pandas version.

See pandas-dev/pandas#35407 for their motivation why they depreciated it.

@quaquel
Copy link
Owner

quaquel commented May 18, 2022

Do you have examples from the code where this syntax is still used? I fixed a number of them in various places as part of the 2.1 release.

@EwoutH
Copy link
Collaborator Author

EwoutH commented May 18, 2022

If you search in a recent CI run on depr or .append you will find some. The difficult thing is that .append() also a method is for other classes.

I tried to use PyCharm to automatically find instances of DataFrame.append(), but couldn't figure out how.

If you take this run for example, there is one in:

complete = complete.append(fs.T, sort=True)

and one in
self.peeling_trajectory = self.peeling_trajectory.append(

These might be the only ones, there might be more.

quaquel added a commit that referenced this issue May 18, 2022
quaquel added a commit that referenced this issue May 18, 2022
replaces DataFrame.append with pd.concat. See #126
@EwoutH
Copy link
Collaborator Author

EwoutH commented Jun 13, 2022

I think all cases are gone, so this issue can be closed. Thanks!

@EwoutH EwoutH closed this as completed Jun 13, 2022
@quaquel
Copy link
Owner

quaquel commented Jun 13, 2022

great, thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants