Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Bad Smells in io.quarkiverse.githubapp.command.airline.deployment.GitHubAppCommandAirlineProcessor #365

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix Bad Smells in io.quarkiverse.githubapp.command.airline.deployment.GitHubAppCommandAirlineProcessor #365

merged 1 commit into from
Sep 12, 2022

Conversation

MartinWitt
Copy link
Contributor

Repairing Code Style Issues

SizeReplaceableByIsEmpty

Checking if a something is empty should be done by Object#isEmpty instead of Object.size==0

Changes:

  • Replaced collection.size empty check with collection.isEmpty

@gsmet gsmet merged commit 725ac52 into quarkiverse:main Sep 12, 2022
@gsmet
Copy link
Member

gsmet commented Sep 12, 2022

Merged, thanks.

@MartinWitt MartinWitt mentioned this pull request Sep 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinWitt @gsmet