Fix instantiation of the exporters for Quarkus v3.2+ #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
from
0e8b67b to
7374302
Compare
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
from
585eb2f to
b6fab76
Compare
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
2 times, most recently
from
94096a7 to
07a660e
Compare
|
The GCP exporter seems to have this native mode problem: quarkusio/quarkus#30293 (comment) |
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
from
6d553e9 to
7f130a9
Compare
alesj
reviewed
Oct 25, 2023
...c/main/java/io/quarkiverse/opentelemetry/exporter/common/runtime/LateBoundSpanProcessor.java
Outdated
Show resolved
Hide resolved
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
from
fa7d72d to
eb9922d
Compare
radcortez
approved these changes
Oct 25, 2023
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
3 times, most recently
from
dfa50b9 to
57c7e9b
Compare
|
I won't be able to fix this for a few weeks... |
…nd fix native mode
brunobat
force-pushed
the
fix-for-quarkus-3-2
branch
from
041baff to
0c92e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #83
This can only be merged after this PR is released: quarkusio/quarkus#36495
This depends of future Quarkus 3.5.0.
Instantiation now uses Synthetic beans.
ExternalOtelExporterBuildItemmust be registered and bean producers are not needed anymore.There will be additional fixes for native mode, on this PR.