doc: clarify that CRDs are never applied in prod mode #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <claprun@redhat.com>
xstefank
reviewed
Nov 26, 2024
| @@ -32,7 +32,10 @@ public interface CRDConfiguration { | |||
|
|
|||
| /** | |||
| * Whether the extension should automatically apply updated CRDs when they change. | |||
| * When running on DEV mode, the CRD changes will always be applied automatically. | |||
| * <p> | |||
| * <strong>NOTE that this option only when *not* in Dev mode as applying the CRD to a production cluster could be | |||
There was a problem hiding this comment.
I'm not sure what this is saying. It applies only in dev and test, correct?
There was a problem hiding this comment.
D'oh! 😓 Opened a new PR to fix this. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com