Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record version with CRD name to properly output multiple versions #973

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

metacosm
Copy link
Member

@metacosm metacosm commented Oct 7, 2024

Also fixes an issue with improperly recorded reconciler name and
handling of generic kubernetes resources.

Fixes #886

Signed-off-by: Chris Laprun claprun@redhat.com

Also fixes an issue with improperly recorded reconciler name and
handling of generic kubernetes resources.

Fixes #886

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested a review from a team as a code owner October 7, 2024 17:49
@metacosm metacosm self-assigned this Oct 7, 2024
@metacosm metacosm requested a review from xstefank October 7, 2024 17:49
@metacosm metacosm merged commit 805dc0a into main Oct 8, 2024
6 checks passed
@metacosm metacosm deleted the fix-886 branch October 8, 2024 11:37
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRD Generator is not generating multiple custom resource versions in case one version is tied to a reconciler
2 participants