Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not limit external CRDs to bundle generation #992

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

metacosm
Copy link
Member

@metacosm metacosm commented Nov 7, 2024

  • refactor: move external CRD configuration to main CRD configuration
  • refactor: load external CRDs from CRD generation step
  • refactor: simplify add method
  • feat: only process CRs that are not excluded

Fixes #867

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested a review from a team as a code owner November 7, 2024 22:38
@metacosm metacosm self-assigned this Nov 7, 2024
@metacosm metacosm requested review from andreaTP and xstefank November 7, 2024 22:38
Fixes #867

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Copy link
Contributor

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, eager to try out all those improvements as soon as I have an occasion!
Thanks!

@metacosm metacosm merged commit 333f2df into 6.8.x Nov 8, 2024
4 checks passed
@metacosm metacosm deleted the more-external-crds branch November 8, 2024 12:51
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With quarkus:dev mode it should be possible to select which CRD to apply
3 participants