Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests in a container, enables "native" on Windows #12

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Karm
Copy link
Contributor

@Karm Karm commented Feb 27, 2023

Fix #13

This PR enables the test suite to run the native executable in a container.
AWT in GraalVM and Quarkus is not supported on Windows to an extent that would satisfy Quarkus Primefaces' needs, so the solution is to run both the build and the runtime in a Linux container.

This PR relies on changes to Quarkus to work with Podman for Windows. I have these changes in a branch: issue-31307-q-2.16. I'll open a PR to Quarkus presently.

How to test?

git clone --branch  issue-31307-q-2.16  https://github.com/Karm/quarkus.git
cd quarkus
./mvnw clean install -Dquickly
cd ..
git clone --branch q-issue-31307 https://github.com/Karm/quarkus-primefaces.git
cd quarkus-primefaces/
podman machine start
mvn clean install -Ddocker -Dnative -Dnative.surefire.skip 
       -Dquarkus.native.container-build=true -Dquarkus.container-image.build=true
       -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel-builder-image:22.3-java17
       -Dquarkus.docker.executable-name=podman
       -Dquarkus.native.container-runtime=podman
       -Dquarkus.version=2.16.999-SNAPSHOT

I tested:

System Podman Docker
CentOS 8 4.0.2 ✔️ 20.10.21 ✔️
Windows 10 4.1.0 ✔️ 20.10.22 ✔️

The Windows run takes a very long time, ~30 minutes with Podman, ~54 minutes with Docker Desktop. It's partially due to the nested virtualization situation on my Linux laptop and also due to the sizing of the WSL2 shim that likely could have been configured better than the default.

@melloware
Copy link
Contributor

Thank you! Should I wait to merge this until the fixes are no longer in SNAPSHOT?

@melloware melloware merged commit cceb830 into quarkiverse:main Feb 27, 2023
@melloware
Copy link
Contributor

@all-contributors add @Karm for bugs

@allcontributors
Copy link
Contributor

@melloware

I've put up a pull request to add @Karm! 🎉

@Karm
Copy link
Contributor Author

Karm commented Feb 28, 2023

@melloware

Thank you! Should I wait to merge this until the fixes are no longer in SNAPSHOT?
yw

I don't think you need to wait. The experience just wouldn't be good for Windows until Quarkus gets updated, but that's not a regression...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Integration Tests on Windows
2 participants