Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
as pointed out on Twitter, amazing stuff.
This is me trying to add Mac support. Problem being
lapjv
doesn't work on Mac and I'd rather fix things on the python side than figuring out Cpp builds. It also seems likelapjv
was never compiled on non-x86 as it pullsimmintrin.h
at the top level.So yeah, I pulled in
lapx
and this is what I get for tests on py312:Hopefully your tests would catch a problem in my commits? 😬
I'm open to trying out more stuff (now I'm moving to actually trying out qbindiff).
Performance-wise I have no idea how
lapx
compares tolapjv
, but from a quick look at the codelapx
isn't doing any fancy optimization.Side note:
matcher.py
mentionscol_indices
butlapjv
calls the same return valuerow_ind_lapjv
. I didn't rename in the outer function, but that looks weird to my monkey brain.