Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests with Quarkus OpenShift extension as upstream issue is fixed #1106

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 11, 2023

Summary

I'll investigate disabled tests next week, but this PR is already WIP for quite long time, let's get it in.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik changed the title Enable tests with Quarkus OpenShift extension as upstream issue is fixed WIP: Enable tests with Quarkus OpenShift extension as upstream issue is fixed Mar 11, 2023
@michalvavrik michalvavrik marked this pull request as draft March 11, 2023 15:48
@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch 4 times, most recently from d8c55ae to a434bbb Compare March 14, 2023 12:06
@michalvavrik michalvavrik changed the title WIP: Enable tests with Quarkus OpenShift extension as upstream issue is fixed Enable tests with Quarkus OpenShift extension as upstream issue is fixed Mar 14, 2023
@michalvavrik michalvavrik marked this pull request as ready for review March 14, 2023 12:07
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik marked this pull request as draft March 15, 2023 09:06
@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from a434bbb to c236ec5 Compare March 17, 2023 10:09
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from c236ec5 to bfd76bf Compare March 17, 2023 14:25
@michalvavrik
Copy link
Member Author

run tests

@rsvoboda
Copy link
Member

@michalvavrik what are your plans with this PR?

@michalvavrik
Copy link
Member Author

@rsvoboda problem is that all tests I tried locally (in OC are green), I think there are some params that CI is using that I didn't. I'll proceed on this today, but I have a lot of work on daily failures.

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from bfd76bf to e345cda Compare March 25, 2023 21:46
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from e345cda to 574cc62 Compare March 27, 2023 19:02
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

michalvavrik commented Mar 28, 2023

Opened quarkusio/quarkus#32193, also CI was adjusted which fixed some of issues.

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from 574cc62 to a3087f0 Compare March 28, 2023 21:36
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from a3087f0 to 527f757 Compare April 2, 2023 08:06
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from 527f757 to 1155289 Compare April 2, 2023 12:11
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from 1155289 to d9f0b68 Compare April 2, 2023 13:39
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from d9f0b68 to 473fed6 Compare April 2, 2023 15:01
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik marked this pull request as ready for review April 2, 2023 18:20
@michalvavrik michalvavrik requested a review from mjurc April 2, 2023 18:20
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mjurc mjurc merged commit 60099e0 into quarkus-qe:main Apr 2, 2023
@michalvavrik michalvavrik deleted the feature/enable-tests-using-oc-extension branch April 2, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants