Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gRPC Infinispan tests by setting SNI as it is required when SSL is used after the latest Infinispan bump #1473

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix gRPC Infinispan tests by setting SNI as it is required when SSL is used after the latest Infinispan bump #1473

merged 1 commit into from
Oct 17, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 16, 2023 •
edited
Loading

Summary

SNI is now required by default when SSL is used, see quarkusio/quarkus#36445. Fixes one daily failure.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik changed the title Fix gRPC Infinispan tests by setting SNI Fix gRPC Infinispan tests by setting SNI as it is required when SSL is used after the latest Infinispan bump Oct 16, 2023
@fedinskiy fedinskiy merged commit 5fd80e8 into quarkus-qe:main Oct 17, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/fix-infinispan-client-sni-validation branch October 17, 2023 08:27
@michalvavrik michalvavrik mentioned this pull request Oct 17, 2023
Merged
10 tasks
@michalvavrik michalvavrik mentioned this pull request Oct 25, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @fedinskiy