-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for kafka-quickstart #249
Add test for kafka-quickstart #249
Conversation
try (SseEventSource source = SseEventSource.target(target).build()) { | ||
source.register(inboundSseEvent -> received.add(Double.valueOf(inboundSseEvent.readData()))); | ||
source.open(); | ||
Thread.sleep(500); // Consume events for just 500 ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you switch to Awaitility instead?
await()atMost(10000).until(() -> received.size() < 5)
received
would need to be a CopyOnWritearrayList
but that would be more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed, great suggestion!
What can I do to solve this PR? I have addressed the change requested. @cescoffier |
Hi,
this PR add test for kafka-quickstart.
Resolves #145