Add some logging to DevModeClient in the case of errors

quarkusio · Nov 29, 2023 · cce888f · cce888f
1 parent 6752370
commit cce888f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/test-framework/devmode-test-utils/pom.xml b/test-framework/devmode-test-utils/pom.xml
@@ -14,6 +14,10 @@
     <name>Quarkus - Test Framework - Dev Mode Test Utils</name>
 
     <dependencies>
+        <dependency>
+            <groupId>org.jboss.logging</groupId>
+            <artifactId>jboss-logging</artifactId>
+        </dependency>
         <dependency>
             <groupId>commons-io</groupId>
             <artifactId>commons-io</artifactId>

diff --git a/...ramework/devmode-test-utils/src/main/java/io/quarkus/test/devmode/util/DevModeClient.java b/...ramework/devmode-test-utils/src/main/java/io/quarkus/test/devmode/util/DevModeClient.java
@@ -19,13 +19,16 @@
 
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.IOUtils;
+import org.jboss.logging.Logger;
 
 import io.smallrye.common.os.OS;
 
 public class DevModeClient {
 
     private static final long DEFAULT_TIMEOUT = OS.current() == OS.WINDOWS ? 3L : 1L;
 
+    private static final Logger LOG = Logger.getLogger(DevModeClient.class);
+
     static long getDefaultTimeout() {
         return DEFAULT_TIMEOUT;
     }
@@ -180,6 +183,10 @@ public String getHttpResponse(String path, boolean allowError, Supplier<String>
                         resp.set(content);
                         return true;
                     } catch (Exception e) {
+                        LOG.error(
+                                "An error occurred when DevModeClient accessed " + path
+                                        + ". It might be a normal testing behavior but logging the exception for information",
+                                e);
                         return false;
                     }
                 });
@@ -206,6 +213,10 @@ public boolean getHttpResponse(String path, int expectedStatus, long timeout, Ti
                         }
                         return false;
                     } catch (Exception e) {
+                        LOG.error(
+                                "An error occurred when DevModeClient accessed " + path
+                                        + ". It might be a normal testing behavior but logging the exception for information",
+                                e);
                         return false;
                     }
                 });
@@ -227,6 +238,10 @@ public boolean getStrictHttpResponse(String path, int expectedStatus) {
                         //complete no matter what the response code was
                         return true;
                     } catch (Exception e) {
+                        LOG.error(
+                                "An error occurred when DevModeClient accessed " + path
+                                        + ". It might be a normal testing behavior but logging the exception for information",
+                                e);
                         return false;
                     }
                 });