-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Using Liquibase in Native Mode a ServiceConfigurationError is Logged #40575
Comments
/cc @Karm (mandrel), @andrejpetras (liquibase), @galderz (mandrel), @geoand (liquibase), @gsmet (liquibase), @radcortez (config), @zakkak (mandrel,native-image) |
cc @famod you looked into this last |
Fix issue with Liquibase and H2 database
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Does this fix only the h2 issue? We too experience this with postgres |
Right, this was closed by mistake. |
How does one reproduce this for postgres? |
I'll try to provide a reproducer, my first guess is the same just with a postgres driver |
You can use the steps outlined in issue 40574 under How to Reproduce? to replicate the error for postgres. |
Brilliant, thank you. |
I can confirm that I get:
when using Postgres, but I have no idea what that means. |
Nevermind the comment above - I see why that happens in native tests.
show up in the logs |
Yes, especially when you don't have an h2 dependency. |
My best guess is that we should always do Line 256 in 509ec82
Do you want to try that out in your applications? |
You're right. This setting is only required to reproduce the issue addressed in the linked topic. |
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Fixes: quarkusio#40575 (cherry picked from commit 509ec82)
Without having it tried yet, as far as I understand, I agree that this probably should not be filtered out as the class will be loaded by the service loader of liquibase: https://github.com/liquibase/liquibase/blob/master/liquibase-standard/src/main/resources/META-INF/services/liquibase.command.CommandStep#L31 |
I'm still experiencing this issue in Quarkus 3.11.2. I see that the fix mentioned above was applied to 3.11 branch: So I guess it is still not fixed. I'm using liquibase in combination with MongoDB dependencies and Kotlin:
Here the stacktrace I get:
It seems to only log this error, but app itself works fine and liquibase migration is also applied correctly. |
Hello team, I am still facing this issue when running native image, it is still not fixed, could you guy update the current status for this issue and when the fix could be released? Many thanks
|
Can someone try #41414 and see if it fixes their problem? |
Describe the bug
When Using Liquibase in Native Mode a ServiceConfigurationError is Logged.
This happens at least with Postgresql and H2.
The issue occurs at least since Quarkus 3.8.2
The error occurs for a local as well as an in-container build.
There seem to be no negative consequences of this error, besides polluting the application log.
Expected behavior
No Error is logged.
Actual behavior
At Quarkus start the following error is logged:
The error is exactly the same for Postgresql and H2.
It probably occurs for other databases as well.
How to Reproduce?
liquibase-quickstart
fromquarkus-quickstarters
.Output of
uname -a
orver
Darwin 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:11:05 PDT 2024; root:xnu-10063.101.17~1/RELEASE_X86_64 x86_64
Output of
java -version
java 21.0.3 2024-04-16 LTS Java(TM) SE Runtime Environment Oracle GraalVM 21.0.3+7.1 (build 21.0.3+7-LTS-jvmci-23.1-b37) Java HotSpot(TM) 64-Bit Server VM Oracle GraalVM 21.0.3+7.1 (build 21.0.3+7-LTS-jvmci-23.1-b37, mixed mode, sharing)
Mandrel or GraalVM version (if different from Java)
No response
Quarkus version or git rev
3.10.0
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Additional information
No response
The text was updated successfully, but these errors were encountered: