Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus application build fails inside a folder that ends with ! #43273

Closed
rsvoboda opened this issue Sep 13, 2024 · 5 comments · May be fixed by quarkusio/quarkus-fs-util#19
Closed

Quarkus application build fails inside a folder that ends with ! #43273

rsvoboda opened this issue Sep 13, 2024 · 5 comments · May be fixed by quarkusio/quarkus-fs-util#19
Labels
area/core kind/bug Something isn't working

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Sep 13, 2024

Describe the bug

Quarkus application build fails inside a folder that ends with !

Build ends with [ERROR] Caused by: java.nio.file.NoSuchFileException: /Users/rsvoboda/tmp/getup!/app-3.14.3/target/quarkus-app/quarkus/transformed-bytecode.jar.
There is a file new file generated outside the application target directory (/Users/rsvoboda/tmp/getup in my case) instead of the transformed-bytecode.jar.

This was discovered as part of the review of #42248. @dmlloyd , in my opinion this is not related to the smallrye/smallrye-common#293 changes as this scenario also fails with Quarkus 3.12.3.

Some details are also in #42248 (comment)

Expected behavior

Quarkus application builds successfully

Actual behavior

transformed-bytecode.jar gets created in different place and Quarkus application build fails

How to Reproduce?

mkdir 'getup!'
cd 'getup!'

Both 3.14.3 and 3.12.3 fail to build the app

mvn io.quarkus.platform:quarkus-maven-plugin:3.12.3:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-3.12.3 -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformVersion=3.12.3 -Dextensions=quarkus-rest
mvn -e clean package -f app-3.12.3

mvn io.quarkus.platform:quarkus-maven-plugin:3.14.3:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-3.14.3 -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformVersion=3.14.3 -Dextensions=quarkus-rest
mvn -e clean package -f app-3.14.3

Output of uname -a or ver

macOS

Output of java -version

Java 21

Quarkus version or git rev

3.14.3

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda
Copy link
Member Author

I also tried Quarkus 3.2 and 2.13 and they fail too, so thi seems to be pretty old bug, but nobody hit that yet or remained silent about it.

mvn io.quarkus.platform:quarkus-maven-plugin:3.2.3.Final:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-3.2.3 -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformVersion=3.2.3.Final
mvn clean package -f app-3.2.3

sdk use maven 3.8.8
mvn io.quarkus.platform:quarkus-maven-plugin:2.13.3.Final:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-2.13.3 -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformVersion=2.13.3.Final
mvn clean package -f app-2.13.3

@gsmet
Copy link
Member

gsmet commented Oct 1, 2024

quarkusio/quarkus-fs-util#19 fixes the build but, well, you won't be able to start the app for other reasons anyway :).

@gsmet
Copy link
Member

gsmet commented Oct 1, 2024

FWIW, I'm not willing to personally chase this more.

@dmlloyd
Copy link
Member

dmlloyd commented Oct 1, 2024

Fixing this further would (I believe) necessarily incur a performance penalty because we'd have to examine the filesystem at each point where we encounter a file that ends in ! to see if it exists before moving on to the JAR it references. I would vote to not fix this, if my vote counts.

@rsvoboda
Copy link
Member Author

rsvoboda commented Oct 2, 2024

Let's go ahead and close for now

@rsvoboda rsvoboda closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants