Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky RabbitMQ integration tests #21061

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Oct 28, 2021

In RabbitMQ queues are what store messsages for processing, while exchanges are what messages are sent to. If an exchange has no bound queues, in most standard cases, any messages sent to the exchange are dropped.

The "incoming" RabbitMQ connector is what creates and binds a queue to an exchange. This fix adds a delay to the "outgoing" messages to ensure the "incoming" connector has time to create and bind the required queue to the required exchange.

In RabbitMQ queues are what store messsages for processing, while exchanges are what messages are sent to. If an exchange has no bound queues, in most standard cases, any messages sent to the exchange are dropped.

The "incoming" RabbitMQ connector is what creates and binds a queue to an exchange. This fix adds a delay to the "outgoing" messages to ensure the "incoming" connector has time to create and bind the required queue to the required exchange.
@kdubb
Copy link
Contributor Author

kdubb commented Oct 28, 2021

@geoand @cescoffier This should fix the issue with RabbitMQ integration tests. Basically it just needs time to make sure the queue is bound to the exchange before sending messages.

@cescoffier My testing has shown that the multi-connect issue fixed via smallrye/smallrye-reactive-messaging#1447 happens nearly every time for outgoing connectors. Any idea when SR RM RabbitMQ 3.11.0 will be released so we can update the Quarkus dependency to include this fix?

@kdubb
Copy link
Contributor Author

kdubb commented Oct 28, 2021

@stuartwdouglas I was the also working to fix the tests. This is essentially the same fix as you are testing in #21056. You can read the above explanation as to why this is needed for RabbitMQ.

@gsmet gsmet merged commit 6894d11 into quarkusio:main Oct 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 28, 2021
@gsmet
Copy link
Member

gsmet commented Oct 28, 2021

Thanks!

@kdubb kdubb deleted the fix/sr_rm_rmq_its branch October 28, 2021 09:37
@cescoffier
Copy link
Member

@kdubb @ozangunalp 3.11 will be in Quarkus 2.5 so mid-november.

@geoand
Copy link
Contributor

geoand commented Oct 28, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants