Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Bump mermaid-js to 9.4.0 #31243

Closed
wants to merge 1 commit into from

Conversation

benedekh
Copy link

Update mermaid-js to 9.4.0, because all versions between 9.1.1 and 9.3.0 use moment-js 2.24.0 as a transitive dependency. moment-js 2.24.0 has two vulnerabilities with CVE identifiers: CVE-2022-31129, CVE-2022-24785. Both of them are with HIGH severity. Luckily, they have been fixed in moment-js 2.29.4 and mermaid-js 9.4.0 depends on this fixed version.

Therefore, I would like to propose a version update for mermaid-js.

Without this update, quarkus-vertx-http-deployment can get marked as a vulnerable library by a dependency checking tool. That is because mermaid-js is packed inside quarkus-vertx-http-deployment.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 17, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Feb 17, 2023
@benedekh benedekh changed the title [WIP] Bump mermaid-js to 9.4.0 WIP - Bump mermaid-js to 9.4.0 Feb 17, 2023
@gsmet
Copy link
Member

gsmet commented Feb 17, 2023

@benedekh thanks but Dependabot beat you to it: #31234 :)

Thanks for providing the context though. I will mark the Dependabot PR for backport.

@gsmet gsmet closed this Feb 17, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Feb 17, 2023
@benedekh
Copy link
Author

@gsmet: Thank you for the quick feedback. It seems to be, version bumps are moving fast. :)

Could you give me an estimate, when a new version of the 2.16 series will be released that contains this bump?

@gsmet
Copy link
Member

gsmet commented Feb 17, 2023

Given this is a dev mode only dependency, I don't feel the urgency to release something.

I released 2.16.3.Final yesterday (still to be announced) so maybe next week if something pressing pops up but most probably the week after that.

@benedekh
Copy link
Author

benedekh commented Feb 28, 2023

@gsmet: I would not like to hurry things, but is there an ETA for the new patch release this week?

Update: Thank you for the release! https://github.com/quarkusio/quarkus/releases/tag/2.16.4.Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants