Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jboss-logmanager #33318

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Switch to jboss-logmanager #33318

merged 1 commit into from
Sep 6, 2023

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented May 11, 2023

Drop the old jboss-logmanager-embedded in favor of jboss-logmanager.

  • Update all relevant POMs to reference jboss-logmanager instead of jboss-logmanager-embedded
  • Remove jboss-logmanager from the banned dependencies list (without replacement)
  • Update jboss-logmanager-embedded to 1.2.0.Final, which is a relocation that points to jboss-logmanager 3.0.0.Final; this artifact will never be changed again
    • n.b. users who have an explicit dependency on this older artifact will automatically be forwarded to the version of jboss-logmanager found in our BOM
  • Update logging extension for API differences
  • Use the upstream banner formatter for the startup banner

(Possibly) Fixes #2152
(Possibly) Fixes #7640
Fixes #9679
Fixes #33109

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/logging area/panache area/vertx labels May 11, 2023
@dmlloyd
Copy link
Member Author

dmlloyd commented May 11, 2023

Looks like the artifact hasn't propagated yet. Will retry CI in 24 hours.

@github-actions
Copy link

github-actions bot commented May 12, 2023

🙈 The PR is closed and the preview is expired.

@geoand
Copy link
Contributor

geoand commented May 16, 2023

@dmlloyd should this be taken out of draft?

@dmlloyd
Copy link
Member Author

dmlloyd commented May 16, 2023

Probably not until 3.0.0.Final is tagged, which depends on testing in WildFly as well.

@geoand
Copy link
Contributor

geoand commented May 16, 2023

👍🏼

@gsmet
Copy link
Member

gsmet commented Jun 6, 2023

@dmlloyd what's the status of this one?

@dmlloyd
Copy link
Member Author

dmlloyd commented Jun 6, 2023

We're still waiting for the WildFly integration and testing to be complete before 3.0.0.Final can be released. I understand that @jamezp is making steady progress on that.

@gsmet
Copy link
Member

gsmet commented Jun 6, 2023

Perfect, thanks for the update.

@geoand
Copy link
Contributor

geoand commented Jun 27, 2023

Does it make sense to use 3.0.0.Beta1 for now?

@dmlloyd
Copy link
Member Author

dmlloyd commented Jun 28, 2023

I'd say that's @gsmet's call; I expect James to release another beta this week or maybe next week, which may have a minor compatibility impact. I still don't know when the final will be ready but I think we're fairly close.

Also there is at least one outstanding PR (#34145) which will probably conflict with this one, which might affect the decision one way or another. I don't mind resolving a conflict here though.

@gsmet
Copy link
Member

gsmet commented Jun 28, 2023

I don't think we are in a hurry on this. So let's wait for the Final.

@geoand
Copy link
Contributor

geoand commented Jun 28, 2023

Cool

@dmlloyd dmlloyd marked this pull request as ready for review July 20, 2023 12:27
@quarkus-bot

This comment has been minimized.

@dmlloyd

This comment was marked as resolved.

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/maven area/vertx area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Sep 1, 2023
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/maven area/panache area/vertx labels Sep 1, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 1, 2023

Not sure if the test is flaky because the failure does not seem to indicate that this PR is responsible

@dmlloyd
Copy link
Member Author

dmlloyd commented Sep 1, 2023

The failure is caused by a bug in a substitution found in smallrye-common-net. Tracked in smallrye/smallrye-common#241.

Update the artifact is released but propagation to central is slow. I'll try to remember to check it over the weekend and re-push (hopefully for the last time!) once it's up.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member

ah ah ah, I merged first :-) Rebase time @dmlloyd!

Drop the old `jboss-logmanager-embedded` in favor of `jboss-logmanager`.
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2023

Failing Jobs - Building 421d3ac

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 20

@geoand geoand merged commit f247cef into quarkusio:main Sep 6, 2023
@quarkus-bot quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Sep 6, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Sep 6, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 6, 2023
@dmlloyd dmlloyd deleted the unified-log branch September 6, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/logging area/maven area/panache area/vertx kind/bugfix kind/enhancement New feature or request
Projects
5 participants