-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to jboss-logmanager
#33318
Switch to jboss-logmanager
#33318
Conversation
Looks like the artifact hasn't propagated yet. Will retry CI in 24 hours. |
🙈 The PR is closed and the preview is expired. |
@dmlloyd should this be taken out of draft? |
Probably not until |
👍🏼 |
@dmlloyd what's the status of this one? |
We're still waiting for the WildFly integration and testing to be complete before 3.0.0.Final can be released. I understand that @jamezp is making steady progress on that. |
Perfect, thanks for the update. |
Does it make sense to use |
I'd say that's @gsmet's call; I expect James to release another beta this week or maybe next week, which may have a minor compatibility impact. I still don't know when the final will be ready but I think we're fairly close. Also there is at least one outstanding PR (#34145) which will probably conflict with this one, which might affect the decision one way or another. I don't mind resolving a conflict here though. |
I don't think we are in a hurry on this. So let's wait for the Final. |
Cool |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Not sure if the test is flaky because the failure does not seem to indicate that this PR is responsible |
The failure is caused by a bug in a substitution found in Update the artifact is released but propagation to central is slow. I'll try to remember to check it over the weekend and re-push (hopefully for the last time!) once it's up. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ah ah ah, I merged first :-) Rebase time @dmlloyd! |
Drop the old `jboss-logmanager-embedded` in favor of `jboss-logmanager`.
Drop the old
jboss-logmanager-embedded
in favor ofjboss-logmanager
.jboss-logmanager
instead ofjboss-logmanager-embedded
jboss-logmanager
from the banned dependencies list (without replacement)jboss-logmanager-embedded
to1.2.0.Final
, which is a relocation that points tojboss-logmanager
3.0.0.Final
; this artifact will never be changed againjboss-logmanager
found in our BOM(Possibly) Fixes #2152
(Possibly) Fixes #7640
Fixes #9679
Fixes #33109