-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return types of substitutions #35847
Fix return types of substitutions #35847
Conversation
This comment has been minimized.
This comment has been minimized.
cc @jerboaa |
.../src/main/java/io/quarkus/restclient/runtime/graal/ClientHttpEngineBuilder43Replacement.java
Outdated
Show resolved
Hide resolved
Resolves issues with new strict checking introduced with oracle/graal#7340
b7b440b
to
4319465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This GraalVM change turned all our CI red. Good there is already a fix. Thumbs up!
Failing Jobs - Building 4319465
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ ⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖
✖
✖
✖
|
CI failures are not related |
Complementary to quarkusio#35847
Complementary to quarkusio#35847 (cherry picked from commit 66fbb2f)
Complementary to quarkusio#35847 (cherry picked from commit 66fbb2f)
Complementary to quarkusio#35847
Resolves issues with new strict checking introduced with oracle/graal#7340 (expected to land in GraalVM for JDK 22)
Openning as draft till the CI run on my fork completes.