Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types of substitutions #35847

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 11, 2023

Resolves issues with new strict checking introduced with oracle/graal#7340 (expected to land in GraalVM for JDK 22)

Openning as draft till the CI run on my fork completes.

@quarkus-bot

This comment has been minimized.

@zakkak zakkak requested a review from geoand September 12, 2023 10:23
@zakkak
Copy link
Contributor Author

zakkak commented Sep 12, 2023

cc @jerboaa

Resolves issues with new strict checking introduced with
oracle/graal#7340
@zakkak zakkak force-pushed the 2023-09-11-fix-return-type-mismatch branch from b7b440b to 4319465 Compare September 12, 2023 10:48
@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 12, 2023
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This GraalVM change turned all our CI red. Good there is already a fix. Thumbs up!

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2023

Failing Jobs - Building 4319465

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 20
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/container-image/maven-invoker-way 

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.6.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.


⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 12, 2023

CI failures are not related

@zakkak zakkak merged commit db0ddb5 into quarkusio:main Sep 12, 2023
46 of 48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 12, 2023
@zakkak zakkak deleted the 2023-09-11-fix-return-type-mismatch branch September 12, 2023 18:59
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 12, 2023
zakkak added a commit to zakkak/quarkus that referenced this pull request Sep 15, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Sep 19, 2023
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Oct 31, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants