Fix headers and preambles in all guides and reintroduce some keywords #36302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for keywords, guide owners will have to reintroduce them back if needed as I wasn't able to do a 1-1 mapping.
quarkus-bot
bot
added
area/docstyle
|
@sberyozkin I can confirm the keyword search is still around so merging this and releasing should actually fix your issue. |
|
🙈 The PR is closed and the preview is expired. |
|
Thanks @gsmet Can you clarify please - should we continue adding keywords to quarkus-main.yaml and quarkus-latest .yaml at https://github.com/quarkusio/quarkusio.github.io ? Or should we add them to the docs only ? |
|
@rsvoboda FYI too |
sberyozkin
approved these changes
Oct 5, 2023
|
@sberyozkin tbh I wasn't the person who did the work. AFAIK, But, yeah, if you want your keywords to be taken into account, you need to do what I did in this PR. |
|
I dropped the ones for main and latest here: quarkusio/quarkusio.github.io#1808 to avoid any confusion. |
benkard
pushed a commit
to benkard/mulkcms2
that referenced
this pull request
Nov 12, 2023
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.217.0` -> `^0.219.0`](https://renovatebot.com/diffs/npm/flow-bin/0.217.2/0.219.0) | | [io.hypersistence:hypersistence-utils-hibernate-62](https://github.com/vladmihalcea/hypersistence-utils) | compile | minor | `3.5.3` -> `3.6.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `3.4.2` -> `3.4.3` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `3.4.2` -> `3.4.3` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.219.0`](flow/flow-bin@1268ec5...c184c5d) [Compare Source](flow/flow-bin@1268ec5...c184c5d) ### [`v0.218.1`](flow/flow-bin@12afce4...1268ec5) [Compare Source](flow/flow-bin@12afce4...1268ec5) ### [`v0.218.0`](flow/flow-bin@dc93913...12afce4) [Compare Source](flow/flow-bin@dc93913...12afce4) </details> <details> <summary>vladmihalcea/hypersistence-utils</summary> ### [`v3.6.0`](https://github.com/vladmihalcea/hypersistence-utils/blob/HEAD/changelog.txt#Version-360---October-12-2023) \================================================================================ Implement QueryStackTraceLogger using StackWalker [#​659](vladmihalcea/hypersistence-utils#659) Add JFR based query logger [#​658](vladmihalcea/hypersistence-utils#658) Adds support for using MonetaryAmount in [@​ElementCollection](https://github.com/ElementCollection) [#​652](vladmihalcea/hypersistence-utils#652) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.4.3`](https://github.com/quarkusio/quarkus/releases/tag/3.4.3) [Compare Source](quarkusio/quarkus@3.4.2...3.4.3) ##### Complete changelog - [#​36408](quarkusio/quarkus#36408) - Ensure that SSE builder works in native - [#​36404](quarkusio/quarkus#36404) - Do not exclude properties from recording that are available in sources that should always be included - [#​36403](quarkusio/quarkus#36403) - IBM Db2 - Register resource bundle classes for reflection - [#​36402](quarkusio/quarkus#36402) - Native Picocli build breaks SSE client - [#​36399](quarkusio/quarkus#36399) - quarkus-jdbc-db2: resource bundle missing - [#​36377](quarkusio/quarkus#36377) - Allow `@ClientHeaderParam` to override User-Agent - [#​36371](quarkusio/quarkus#36371) - Fix issue in Java migration in dev-mode - [#​36351](quarkusio/quarkus#36351) - Properly handle invalid response body errors in Reactive REST Client - [#​36329](quarkusio/quarkus#36329) - Custom User-Agent header ignored - [#​36326](quarkusio/quarkus#36326) - Cannot load fixed or default YAML configuration when running native build - [#​36302](quarkusio/quarkus#36302) - Fix headers and preambles in all guides and reintroduce some keywords - [#​36299](quarkusio/quarkus#36299) - quarkus-flyway: Java-Migration does not get picked up on live reload - [#​36290](quarkusio/quarkus#36290) - Fixed URL for configuring JSON support - [#​36257](quarkusio/quarkus#36257) - Rest client call hangs when receiving an invalid chunked response and does not release resources (e.g. Bulkhead semaphore) - [#​36147](quarkusio/quarkus#36147) - Bump org.eclipse.parsson:parsson from 1.1.2 to 1.1.4 - [#​36096](quarkusio/quarkus#36096) - Build cache - Use notCacheableBecause instead of storeEnabled - [#​35929](quarkusio/quarkus#35929) - Do not store build cache for core extensions having config - [#​35927](quarkusio/quarkus#35927) - Build cache - Core extensions containing config shouldn't be cached - [#​35769](quarkusio/quarkus#35769) - Default response content type using GraphQL spec </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.4.3`](quarkusio/quarkus-platform@3.4.2...3.4.3) [Compare Source](quarkusio/quarkus-platform@3.4.2...3.4.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some remaining issues in the preambles of some guides with some additional new lines that are causing issues. Also some guides were missing the header redirecting the contributors here.
As for keywords, guide owners will have to reintroduce them back if needed as I wasn't able to do a 1-1 mapping.
Sorry, there is some noise with VS Code cleaning up the new lines.
@sberyozkin this should help with what you reported about
twitternot being found. The infra to push them to the index was already there but the keywords went missing. Note that I haven't been able to add all the keywords that were in the original index as I had troubles finding a 1-1 mapping between the old guides and the new structure. In any case, no need to add thesecuritykeywords everywhere as done before as it's in the title already.Fixes quarkusio/quarkusio.github.io#1800